Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl leave tmp directories behind #1099

Merged
merged 12 commits into from
Jul 13, 2023
Merged

Problem: memiavl leave tmp directories behind #1099

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7b72cd9
cleanup doc
mmsqe Jul 12, 2023
8edb099
cleanup tmp dir on load
mmsqe Jul 12, 2023
f08be9f
cleanup tmp dir on err
mmsqe Jul 12, 2023
434d4ac
add test
mmsqe Jul 12, 2023
6af2463
log remove err
mmsqe Jul 12, 2023
ca49481
Apply suggestions from code review
mmsqe Jul 12, 2023
51ecbe6
limit total removal instead of concurrency
mmsqe Jul 12, 2023
84f22df
add change doc
mmsqe Jul 12, 2023
77e55f0
rm go func
mmsqe Jul 12, 2023
5fa3988
simplify
yihuang Jul 12, 2023
a0beaa1
propogate error
yihuang Jul 12, 2023
c09896c
Merge remote-tracking branch 'origin/main' into cleanup_tmp
mmsqe Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
propogate error
  • Loading branch information
@yihuang
yihuang committed Jul 12, 2023
commit a0beaa16073deebc1691a9bde0cc80b7beb8b803
5 changes: 1 addition & 4 deletions memiavl/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,7 @@ func (db *DB) RewriteSnapshot() error {
return err
}
if err := db.MultiTree.WriteSnapshot(path); err != nil {
if err := os.RemoveAll(path); err != nil {
db.logger.Error("failed to remove tmp directories", "err", err)
}
return err
return errors.Join(err, os.RemoveAll(path))
}
if err := os.Rename(path, filepath.Join(db.dir, snapshotDir)); err != nil {
return err
Expand Down