Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ethermint develop branch is not used #1069

Merged
merged 17 commits into from
Jul 5, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 19, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1069 (68ff959) into main (b181dda) will decrease coverage by 0.22%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
- Coverage   46.55%   46.33%   -0.22%     
==========================================
  Files          80       80              
  Lines        7250     7251       +1     
==========================================
- Hits         3375     3360      -15     
- Misses       3514     3531      +17     
+ Partials      361      360       -1     
Impacted Files Coverage Δ
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/params.go 73.52% <ø> (ø)
x/cronos/middleware/conversion_middleware.go 4.54% <ø> (ø)
x/cronos/rpc/api.go 0.35% <0.00%> (-0.01%) ⬇️
x/cronos/keeper/ibc.go 80.43% <76.92%> (-1.66%) ⬇️

... and 1 file with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review June 20, 2023 05:57
@mmsqe mmsqe requested a review from a team as a code owner June 20, 2023 05:57
@mmsqe mmsqe requested review from JayT106 and devashishdxt and removed request for a team June 20, 2023 05:57
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
the ibc go has released v6.2. maybe uses this instead of v6.1 ?

go.mod Show resolved Hide resolved
@yihuang yihuang added this pull request to the merge queue Jun 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2023
@mmsqe mmsqe enabled auto-merge June 21, 2023 12:00
@mmsqe mmsqe added this pull request to the merge queue Jun 21, 2023
@mmsqe mmsqe removed this pull request from the merge queue due to a manual request Jun 21, 2023
@mmsqe mmsqe added this pull request to the merge queue Jul 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2023
@mmsqe mmsqe added this pull request to the merge queue Jul 5, 2023
Merged via the queue into crypto-org-chain:main with commit 51e5552 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants