Skip to content

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jun 5, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe force-pushed the update_ethermint_ws branch from e893729 to 5b025f1 Compare June 5, 2023 09:16
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1058 (c36c946) into main (71af68e) will increase coverage by 24.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1058       +/-   ##
===========================================
+ Coverage   21.67%   46.26%   +24.58%     
===========================================
  Files          50       82       +32     
  Lines        3026     7124     +4098     
===========================================
+ Hits          656     3296     +2640     
- Misses       2306     3476     +1170     
- Partials       64      352      +288     

see 47 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review June 6, 2023 02:53
@mmsqe mmsqe requested a review from a team as a code owner June 6, 2023 02:53
@mmsqe mmsqe requested review from JayT106 and devashishdxt and removed request for a team June 6, 2023 02:53
@yihuang yihuang enabled auto-merge June 8, 2023 16:18
@mmsqe mmsqe requested a review from yihuang June 9, 2023 01:55
@yihuang yihuang added this pull request to the merge queue Jun 14, 2023
@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label Jun 14, 2023
Merged via the queue into crypto-org-chain:main with commit eadb705 Jun 14, 2023
yihuang pushed a commit to yihuang/cronos that referenced this pull request Jun 14, 2023
…rg-chain#1058)

Solution:
* update ethermint dependency

* add change doc

* add config for depguard when bump to v1.53.x

for more info, see https://github.com/OpenPeeDeeP/depguard\#example-configs

* more allow

* disable depguard

* keep gin-gonic no change
yihuang pushed a commit that referenced this pull request Jun 14, 2023
…1061)

Solution:
* update ethermint dependency

* add change doc

* add config for depguard when bump to v1.53.x

for more info, see https://github.com/OpenPeeDeeP/depguard\#example-configs

* more allow

* disable depguard

* keep gin-gonic no change

Co-authored-by: mmsqe <mavis@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants