Skip to content

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented May 29, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner May 29, 2023 03:33
@yihuang yihuang requested review from calvinaco and thomas-nguy and removed request for a team May 29, 2023 03:33
@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label May 29, 2023
@yihuang yihuang enabled auto-merge May 29, 2023 03:43
yihuang pushed a commit to yihuang/cronos that referenced this pull request May 29, 2023
@yihuang yihuang added this pull request to the merge queue May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1046 (76fe3e5) into main (d65e6f3) will decrease coverage by 23.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1046       +/-   ##
===========================================
- Coverage   46.72%   22.76%   -23.97%     
===========================================
  Files          82       50       -32     
  Lines        7124     3026     -4098     
===========================================
- Hits         3329      689     -2640     
+ Misses       3442     2272     -1170     
+ Partials      353       65      -288     

see 47 files with indirect coverage changes

Merged via the queue into crypto-org-chain:main with commit 03fc136 May 29, 2023
@yihuang yihuang deleted the update-go branch May 29, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants