Problem: ReadUpgradeInfoFromDisk cause panic on startup occasionally

[yihuang]

Don't merge, try to reproduce the issue in CI

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

[codecov]

Codecov Report

Merging #561 (0f8aaa0) into master (0c8568a) will decrease coverage by 10.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #561       +/-   ##
===========================================
- Coverage   21.11%   11.04%   -10.08%     
===========================================
  Files          69       34       -35     
  Lines        9122     4809     -4313     
===========================================
- Hits         1926      531     -1395     
+ Misses       6647     4195     -2452     
+ Partials      549       83      -466     

Flag	Coverage Δ
integration_tests	∅ <ø> (∅)
unit_tests	11.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/encoding.go	0.00% <0.00%> (-100.00%)	⬇️
x/nft/types/denom.go	0.00% <0.00%> (-100.00%)	⬇️
x/nft/types/keys.go	0.00% <0.00%> (-58.98%)	⬇️
x/nft/types/nft.go	0.00% <0.00%> (-52.95%)	⬇️
x/nft/keeper/msg_server.go	0.00% <0.00%> (-46.70%)	⬇️
app/app.go	0.68% <0.00%> (-35.38%)	⬇️
x/nft/types/nft.pb.go	0.60% <0.00%> (-21.99%)	⬇️
x/nft/types/tx.pb.go	0.00% <0.00%> (-16.14%)	⬇️
x/nft/types/genesis.go	0.00% <0.00%> (-9.10%)	⬇️
x/nft/client/cli/query.go	60.12% <0.00%> (-8.23%)	⬇️
... and 44 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8568a...0f8aaa0. Read the comment docs.

[yihuang]

upstream fix: cosmos/cosmos-sdk#9384

[leejw51crypto]

ok

[yihuang]

cosmos/cosmos-sdk#9384
upstream fixed, not released yet. included in the 0.43-rc0.

[yihuang]

opened issue #589, closing now.