Skip to content

Fix number of digit computation for decompose in IntegerRing.java. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
this-kramer merged 3 commits into from
Apr 5, 2021
Merged

Fix number of digit computation for decompose in IntegerRing.java. #75

this-kramer merged 3 commits into from
Apr 5, 2021

Conversation

@this-kramer
Copy link
Member

@this-kramer this-kramer commented Apr 5, 2021

Reason for this PR:

  • Decompose function of IntegerRing always returns an array of size 1

Changes in this PR:

  • Bugfix

@this-kramer this-kramer requested a review from JanBobolz April 5, 2021 17:33
JanBobolz
JanBobolz approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@JanBobolz JanBobolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks! :)

@this-kramer this-kramer merged commit 287e097 into develop Apr 5, 2021
@this-kramer this-kramer deleted the hotfix/base-decompose-integer-ring branch June 23, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JanBobolz JanBobolz JanBobolz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@this-kramer @JanBobolz