Passing exceptions on group op worker threads to waiting threads. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an exception occured during some computation (say, you're trying to compute e(g2, g2)), the worker thread just swallowed the exception and the waiting (main) thread hangs forever, waiting for a result whose computation was aborted.
This often gave the appearance that the program hangs because some race condition appeared. The actual error was never actually displayed if the computation happened on a background thread.
With this pull request, any errors are now also passed to threads waiting for the computation to finish, so exceptions are now properly displayed and programs won't hang mysteriously anymore.