Skip to content

fix(albedo): fix incorrect division in Bougamont method #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gampnico wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix(albedo): fix incorrect division in Bougamont method #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cosipy/modules/albedo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,8 @@ def method_Bougamont(GRID, surface_temperature: float, albedo_snow: float):
temperature-dependant decay timescales."""

# slightly faster than one-liner
t_star_days = float(t_star) * float(dt_days)
delta_albedo = albedo_snow - albedo_firn
albedo_snow -= delta_albedo / t_star_days
albedo_snow -= delta_albedo * float(dt_days) / float(t_star)

# Reset if snowfall in current timestep
if hours_since_snowfall == 0:
Expand Down
7 changes: 5 additions & 2 deletions cosipy/tests/test_parameterisation_albedo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ def test_updateAlbedo_method(
surface_temperature=270.0,
albedo_snow=Constants.albedo_fresh_snow,
)
assert isinstance(surface_albedo, float)
assert isinstance(snow_albedo, float)
for albedo in [surface_albedo, snow_albedo]:
assert isinstance(albedo, float)
assert 0.0 <= albedo <= 1.0



@pytest.mark.parametrize("arg_method", ["Wrong Method", "", None])
def test_updateAlbedo_method_error(
Expand Down
Loading