Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): remove API endpoints that redirect clients to newer API versioned endpoints #584

Merged
merged 146 commits into from
Oct 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
146 commits
Select commit Hold shift + click to select a range
f680496
handle CustomeDiscovery PERMANENT_REDIRECT
aali309 Jul 25, 2024
d816ae3
cleanup CustomeDiscoveryTest
aali309 Jul 25, 2024
6df1c5c
remove Discovery redirect
aali309 Jul 29, 2024
b92a525
handle Events PERMANENT_REDIRECT
aali309 Jul 29, 2024
a784a5a
handle EventTemplates PERMANENT_REDIRECT
aali309 Jul 29, 2024
69f7183
delete GraphQL.java
aali309 Jul 29, 2024
dac2561
remove JMCAgent redirect
aali309 Jul 30, 2024
f76bb3e
handle Recordings PERMANENT_REDIRECT && Todo: fix failing tests
aali309 Jul 30, 2024
db05ecb
debug SnapShotTest on CI
aali309 Jul 31, 2024
ac788df
pushed to debug latest updates
aali309 Jul 31, 2024
9ead30b
V2snapcreation fails
aali309 Aug 1, 2024
1be6449
handle Recordings PERMANENT_REDIRECT
aali309 Aug 2, 2024
3fb7647
handle Targets PERMANENT_REDIRECT
aali309 Aug 2, 2024
3ae570e
update permissions
aali309 Aug 2, 2024
8eb9ecd
revert permission changes
aali309 Aug 6, 2024
a13d9bd
fix line breaks && V1 API
aali309 Aug 13, 2024
341afa3
remove ApiResponse
aali309 Aug 13, 2024
87a2be2
remove v2 endpoint and v2Response on Snapshot
aali309 Aug 13, 2024
7b11672
remove v2 endpoint and v2Response on CustomTargets
aali309 Aug 13, 2024
abc1c2b
remove v2 endpoint and v2Response on Events
aali309 Aug 14, 2024
7cfe3c2
remove v2 endpoint and v2Response on Rules
aali309 Aug 16, 2024
310d698
remove v2 endpoint and v2Response on MatchExpressions
aali309 Aug 16, 2024
b36924d
remove v2Response on JMCAgent
aali309 Aug 16, 2024
48f8fce
remove v2Response on JMCAgent
aali309 Aug 16, 2024
b021f6d
remove v2.2 endpont and v2Response on Credentials
aali309 Aug 16, 2024
026656f
remove v2.2 endpont and replace with v3
aali309 Aug 16, 2024
e0f1f76
chore(schema): automatic update
Aug 16, 2024
9a22394
replace v3 -> v4
aali309 Aug 16, 2024
4280409
chore(schema): automatic update
Aug 16, 2024
507aa2b
resolved issues
aali309 Aug 19, 2024
dcf3105
delete v2Response
aali309 Aug 19, 2024
64ee073
cleanup
andrewazores Aug 19, 2024
eefdfec
resolve created Location header relative to current request
andrewazores Aug 19, 2024
1e72415
include created entity in response
andrewazores Aug 19, 2024
99cbae3
refactor
andrewazores Aug 19, 2024
151e26e
return result type directly
andrewazores Aug 19, 2024
0b39a72
conversion API v1 -> v4
aali309 Aug 20, 2024
44efc99
resolve issues
aali309 Aug 20, 2024
a5059cf
chore(schema): automatic update
Aug 20, 2024
bc3b9fd
clean up Health endpoints
andrewazores Aug 20, 2024
92fb3bf
remove some sleeps
andrewazores Aug 20, 2024
38b2967
add CredentialCheck test
andrewazores Aug 20, 2024
619571e
handle CustomeDiscovery PERMANENT_REDIRECT
aali309 Jul 25, 2024
82b8af7
cleanup CustomeDiscoveryTest
aali309 Jul 25, 2024
9268b79
remove Discovery redirect
aali309 Jul 29, 2024
12f7bea
handle Events PERMANENT_REDIRECT
aali309 Jul 29, 2024
932b1da
handle EventTemplates PERMANENT_REDIRECT
aali309 Jul 29, 2024
8eb70e8
delete GraphQL.java
aali309 Jul 29, 2024
f9b744a
remove JMCAgent redirect
aali309 Jul 30, 2024
f03063e
handle Recordings PERMANENT_REDIRECT && Todo: fix failing tests
aali309 Jul 30, 2024
4208b3c
debug SnapShotTest on CI
aali309 Jul 31, 2024
3e6b525
pushed to debug latest updates
aali309 Jul 31, 2024
341008c
V2snapcreation fails
aali309 Aug 1, 2024
c2581cd
handle Recordings PERMANENT_REDIRECT
aali309 Aug 2, 2024
18dd343
handle Targets PERMANENT_REDIRECT
aali309 Aug 2, 2024
304514e
revert permission changes
aali309 Aug 6, 2024
b97d4e0
fix line breaks && V1 API
aali309 Aug 13, 2024
e5af31b
remove ApiResponse
aali309 Aug 13, 2024
5499c95
remove v2 endpoint and v2Response on Snapshot
aali309 Aug 13, 2024
0112785
remove v2 endpoint and v2Response on CustomTargets
aali309 Aug 13, 2024
b2760f7
remove v2 endpoint and v2Response on Events
aali309 Aug 14, 2024
1b5bf10
remove v2 endpoint and v2Response on Rules
aali309 Aug 16, 2024
7f72b91
remove v2 endpoint and v2Response on MatchExpressions
aali309 Aug 16, 2024
527b26d
remove v2Response on JMCAgent
aali309 Aug 16, 2024
88b8a77
remove v2Response on JMCAgent
aali309 Aug 16, 2024
1b2f8a2
remove v2.2 endpont and v2Response on Credentials
aali309 Aug 16, 2024
e7cd344
remove v2.2 endpont and replace with v3
aali309 Aug 16, 2024
68569d1
chore(schema): automatic update
Aug 16, 2024
7cf8548
replace v3 -> v4
aali309 Aug 16, 2024
cc694f0
chore(schema): automatic update
Aug 16, 2024
af0e0eb
resolved issues
aali309 Aug 19, 2024
1a69601
delete v2Response
aali309 Aug 19, 2024
11d2341
cleanup
andrewazores Aug 19, 2024
9239f84
resolve created Location header relative to current request
andrewazores Aug 19, 2024
d4b8bc2
include created entity in response
andrewazores Aug 19, 2024
d212993
refactor
andrewazores Aug 19, 2024
bb41533
return result type directly
andrewazores Aug 19, 2024
d5383cc
conversion API v1 -> v4
aali309 Aug 20, 2024
a2d9102
resolve issues
aali309 Aug 20, 2024
7757ff5
chore(schema): automatic update
Aug 20, 2024
5a9a347
clean up Health endpoints
andrewazores Aug 20, 2024
a1fbb9f
remove some sleeps
andrewazores Aug 20, 2024
06c38e2
add CredentialCheck test
andrewazores Aug 20, 2024
7f79e59
Merge remote-tracking branch 'atali/removeApiRedirect' into removeApi…
andrewazores Aug 21, 2024
3509828
clean up Credentials, add CredentialsTest
andrewazores Aug 21, 2024
9107b55
custom targets API schema fixup, reimplement tests
andrewazores Aug 21, 2024
ca9efdd
Merge branch 'api-v4' into removeApiRedirect
andrewazores Aug 26, 2024
9488092
clean up Rules, RulesTest
andrewazores Aug 26, 2024
9aea517
reset database between custom discovery tests
andrewazores Aug 26, 2024
98366eb
fixup match expression test
andrewazores Aug 26, 2024
0c27f07
remove CustomTargetsTest response type nested access
andrewazores Aug 26, 2024
62c0bc6
ensure databse properly reset after test completion
andrewazores Aug 26, 2024
b161a2b
remove useless test file
andrewazores Aug 27, 2024
9cac11a
adjust Rules itests
andrewazores Aug 27, 2024
ddf6624
remove numMatchingTargets - clients should just use targets.length in…
andrewazores Aug 27, 2024
4c284e5
remove V2 response format from discovery plugin registration
andrewazores Aug 27, 2024
e573617
promote beta endpoints to v4
andrewazores Aug 27, 2024
e47d2f2
avoid pointless use of Response/RestResponse
andrewazores Aug 27, 2024
d6dc5d5
update schema
andrewazores Aug 27, 2024
9e20ebc
prefix credentials check endpoint
andrewazores Aug 27, 2024
8b7b747
add DiscoveryTest
andrewazores Aug 27, 2024
035010e
fixup! prefix credentials check endpoint
andrewazores Aug 27, 2024
2056007
split event templates classes, add tests
andrewazores Aug 27, 2024
0725e07
Merge branch 'api-v4' into removeApiRedirect
andrewazores Aug 28, 2024
9ed15b5
fix up integration test status code assertion
andrewazores Aug 28, 2024
2bbff45
remove useless RestResponse wrapper, add tests
andrewazores Aug 28, 2024
c580afd
schema update script works with httpie
andrewazores Aug 28, 2024
f66c160
update schema
andrewazores Aug 28, 2024
eb0c418
cleanup
andrewazores Aug 28, 2024
4f1bf09
split JMC Agents endpoints by templates vs probes
andrewazores Aug 29, 2024
0c063f7
add JMC Agent tests
andrewazores Aug 29, 2024
bd929fe
handle delete nonexistent archived files, add some tests
andrewazores Aug 29, 2024
de63dea
fixup! split JMC Agents endpoints by templates vs probes
andrewazores Aug 30, 2024
95ed1b8
split recordings endpoints by active vs archived
andrewazores Aug 30, 2024
f958f25
split out snapshots, recording downloads, archived recordings
andrewazores Aug 30, 2024
9ec970d
cleanup
andrewazores Aug 30, 2024
02b86f2
rename methods, add tests
andrewazores Aug 30, 2024
a76af08
add new recording download endpoint relative to target path
andrewazores Aug 30, 2024
22e7b59
rename path parameter, add tests
andrewazores Aug 30, 2024
6603da8
rename path parameter, add tests, fix bug
andrewazores Aug 30, 2024
ab2cfd4
add active recording download test
andrewazores Aug 30, 2024
92b59ec
fixup! rename path parameter, add tests, fix bug
andrewazores Aug 30, 2024
6ba5215
add archived recording tests, fix archive key lookup bug
andrewazores Aug 30, 2024
cef7606
cleanup
andrewazores Sep 3, 2024
fd01abf
restore permissions
andrewazores Sep 3, 2024
cdd481f
add report generation unit tests
andrewazores Sep 3, 2024
bf14cdf
add auth tests
andrewazores Sep 3, 2024
7656162
add truststore test
andrewazores Sep 3, 2024
f5555d4
fixup! add report generation unit tests
andrewazores Sep 3, 2024
5f030bb
clean up paths, add targets list/get tests
andrewazores Sep 3, 2024
d0f87e6
correct paths conflict
andrewazores Sep 3, 2024
56dea2b
Merge branch 'api-v4' into removeApiRedirect
andrewazores Sep 3, 2024
8e45fe0
don't serialize logger in responses
andrewazores Sep 3, 2024
d9d17f3
remove itests which will never be re-enabled
andrewazores Sep 3, 2024
7f2f69a
remove V2 format from discovery responses
andrewazores Sep 4, 2024
f0cd4fe
spotless
andrewazores Sep 4, 2024
aa0dbdf
disable test re-runs which never pass anyway
andrewazores Sep 4, 2024
70566da
comment out flakey ordering-sensitive assertions
andrewazores Sep 4, 2024
5b6faf0
include jvmId in responses and notifications rather than connectUrl
andrewazores Sep 5, 2024
eb52cd6
fixup! include jvmId in responses and notifications rather than conne…
andrewazores Sep 5, 2024
5d6413f
chore(schema): automatic update
Sep 5, 2024
93d3703
Revert "fixup! include jvmId in responses and notifications rather th…
andrewazores Sep 5, 2024
08bb790
Revert "include jvmId in responses and notifications rather than conn…
andrewazores Sep 5, 2024
5a2acc3
include jvmId in archived recording event
andrewazores Sep 5, 2024
d486c73
Merge remote-tracking branch 'upstream/main' into removeApiRedirect
andrewazores Sep 13, 2024
8df6dab
Merge remote-tracking branch 'upstream/main' into removeApiRedirect
andrewazores Oct 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fixup! include jvmId in responses and notifications rather th…
…an connectUrl"

This reverts commit eb52cd6.
  • Loading branch information
andrewazores committed Sep 5, 2024
commit 93d370386cd16ae89b5477471588eee98073b460
6 changes: 4 additions & 2 deletions src/test/java/itest/GraphQLTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,10 @@ void testStartRecordingMutationOnSpecificTarget() throws Exception {
notification.getJsonObject("message").getJsonObject("recording");
MatcherAssert.assertThat(notificationRecording.getString("name"), Matchers.equalTo("test"));
MatcherAssert.assertThat(
notification.getJsonObject("message").getString("jvmId"),
Matchers.not(Matchers.blankOrNullString()));
notification.getJsonObject("message").getString("target"),
Matchers.equalTo(
String.format(
"service:jmx:rmi:///jndi/rmi://%s:%d/jmxrmi", "localhost", 0)));
JsonArray notificationLabels =
notificationRecording.getJsonObject("metadata").getJsonArray("labels");
Map<String, String> expectedLabels =
Expand Down