Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(strings): update user string #1164

Closed
wants to merge 1 commit into from
Closed

chore(strings): update user string #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion locales/en/public.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"MAXIMUM_SIZE": "Maximum size ({{unit}})",
"SAVE_CHANGES": "Save changes",
"TEMPLATE_HELPER_TEXT": "The Event Template to be applied to Automated Analysis recordings.",
"TEMPLATE_INVALID_WARNING": "WARNING: Setting a Target Template as a default template type configuration may not apply to all Target JVMs if the JVMs do not support them."
"TEMPLATE_INVALID_WARNING": "WARNING: Setting the Target Template as a default template type configuration may not apply to all Target JVMs if the JVMs do not support them."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change. It's describing event templates of the kind "Target", as opposed to "Custom":

image

There are usually at least two such Target Templates for any given target application.

This warning is to say that if you pick a Target Template, then this only makes sense if every other Target has that same kind of Template (matching by name).

To give a concrete example of such an invalid configuration:

image

I could select the Cryostat event template here, but any configuration using this template (Automated Analysis card, Automated Rule) would not be able to apply this event template to another target which doesn't have that same template:

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll keep it how it is 👍

},
"AutomatedAnalysisScoreFilter": {
"CURRENT_SCORE_TEXT": "Only showing analysis results with severity scores ≥ {{ val }}:",
Expand Down
Loading