Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(topology): check for jvmId in notifications from Cryostat #1152

Merged
merged 2 commits into from
Nov 1, 2023
Merged

chore(topology): check for jvmId in notifications from Cryostat #1152

merged 2 commits into from
Nov 1, 2023

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Oct 31, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to: https://github.com/cryostatio/cryostat/issues/1452
Related to: #1126

@mwangggg mwangggg marked this pull request as draft October 31, 2023 20:52
@mergify mergify bot added the safe-to-test label Oct 31, 2023
@mwangggg mwangggg closed this Oct 31, 2023
@mwangggg mwangggg force-pushed the 1452-target-include-jvmID-web branch from f849775 to c75c36a Compare October 31, 2023 20:53
@mwangggg mwangggg reopened this Oct 31, 2023
@mwangggg mwangggg added the chore Refactor, rename, cleanup, etc. label Oct 31, 2023
@mwangggg mwangggg marked this pull request as ready for review October 31, 2023 20:56
@andrewazores
Copy link
Member

/build_test

@github-actions GitHub Actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1152-38a4633497b7b41f1ad48d8a8f42e1782a908f54 sh smoketest.sh

@mwangggg
Copy link
Member Author

mwangggg commented Nov 1, 2023

https://github.com/cryostatio/cryostat-web/actions/runs/6712635943

@andrewazores andrewazores merged commit 792a894 into cryostatio:main Nov 1, 2023
21 checks passed
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
@mwangggg @mergify
chore(topology): check for jvmId in notifications from Cryostat (#1152)
93dcf70 
(cherry picked from commit 792a894)
@mergify mergify bot mentioned this pull request Nov 1, 2023
Merged
andrewazores pushed a commit that referenced this pull request Nov 1, 2023
@mergify @mwangggg
chore(topology): check for jvmId in notifications from Cryostat (#1152)…
37229d6 
… (#1154)

(cherry picked from commit 792a894)

Co-authored-by: Ming Yu Wang <90855268+mwangggg@users.noreply.github.com>
@mwangggg mwangggg deleted the 1452-target-include-jvmID-web branch March 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@tthvo tthvo Awaiting requested review from tthvo

@aali309 aali309 Awaiting requested review from aali309

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwangggg @andrewazores