-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discovery): add cryostat-agent discovery plugin #45
Conversation
3f19eed
to
14f8138
Compare
The agent JAR is also now published (automatically) as a package on the GitHub Packages Maven repository: https://github.com/cryostatio/cryostat-agent/packages/1601815
The latest commits use that GitHub Packages JAR, but this requires some setup for the end user in |
b94657d
to
4e6c7ee
Compare
e1107bd
to
2ee1253
Compare
37b6aa0
to
ed0fa2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good overall. The GitHub Maven repository manual setup seems unfortunate, but I imagine this will integrate more smoothly with CI than needing to clone and mvn install
the dependency like we do with -core.
Yea, I tried a few different things (now erased from the commit history) to try to get the CI build working within this PR, but I couldn't figure it out. Always a Consumers of the upstream -agent .jar might be okay with this manual GH Packages setup step, otherwise maybe we need to look at publishing to ex. Maven Central when the agent is ready for primetime. For downstream builds there's already some system for publishing JARs, so that should be relatively straightforward. |
Dropping this, since the Agent is now available on Maven Central as well as on quay.io as an init container (both unauthenticated), and we have other published examples of how to consume the Agent in an application container (ex. test-applications repository). |
Related to https://github.com/cryostatio/cryostat/issues/936
Just a draft for now, mostly meant to share what the setup looks like to add the new
cryostat-agent
to a Quarkus containerized application.