Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(manifest): corrections for multiarch manifest load and create #1557

Merged
merged 2 commits into from
Jun 15, 2023
Merged

ci(manifest): corrections for multiarch manifest load and create #1557

merged 2 commits into from
Jun 15, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1556

@andrewazores
ci(images): tag loaded images more descriptively
0a8f180
@andrewazores
ci(manifest): specify reading images from 'containers-storage:'
9f9d4db 
else manifest creation tries to read from remote, where containers do not yet exist
@andrewazores andrewazores requested a review from ebaron June 15, 2023 18:12
@mergify mergify bot added the safe-to-test label Jun 15, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1557-9f9d4dbf88fc4d4d140a6ea2f3a4ae70e3343301-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1557-9f9d4dbf88fc4d4d140a6ea2f3a4ae70e3343301-linux-arm64 sh smoketest.sh

1 similar comment
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1557-9f9d4dbf88fc4d4d140a6ea2f3a4ae70e3343301-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1557-9f9d4dbf88fc4d4d140a6ea2f3a4ae70e3343301-linux-amd64 sh smoketest.sh

@andrewazores andrewazores merged commit dd10c8e into cryostatio:main Jun 15, 2023
@andrewazores andrewazores deleted the ci-manifest-creation branch June 15, 2023 20:33
@andrewazores andrewazores mentioned this pull request Jun 15, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
ci fix safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @ebaron