Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): implement HTTP-based recordings queries to -agents #1423

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Mar 21, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

See #1415 #1419
Related to #1416
Related to #1309
Related to #520

Description of the change:

Like #1415 and #1419. This one queries information about active recordings.

Motivation for the change:

Same as before

How to manually test:

Needs cryostatio/cryostat-agent#82
Apply the following patch:

diff --git a/smoketest.sh b/smoketest.sh
index 4aebf722..15dbd3f4 100755
--- a/smoketest.sh
+++ b/smoketest.sh
@@ -158,7 +158,7 @@ runDemoApps() {
         --env CRYOSTAT_AGENT_BASEURI="${protocol}://localhost:${webPort}/" \
         --env CRYOSTAT_AGENT_TRUST_ALL="true" \
         --env CRYOSTAT_AGENT_AUTHORIZATION="Basic $(echo user:pass | base64)" \
-        --env CRYOSTAT_AGENT_REGISTRATION_PREFER_JMX="true" \
+        --env CRYOSTAT_AGENT_REGISTRATION_PREFER_JMX="false" \
         --env CRYOSTAT_AGENT_HARVESTER_PERIOD_MS=60000 \
         --env CRYOSTAT_AGENT_HARVESTER_MAX_FILES=10 \
         --rm -d quay.io/andrewazores/quarkus-test:latest

Testing procedure is the same as before, but this time go to the Recordings view. Select the quarkus-test-agent with port 9977 sample application. The active recordings table should populate.

@mergify mergify bot added the safe-to-test label Mar 21, 2023
@andrewazores andrewazores added the feat New feature or request label Mar 21, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1423-3c747e213da163ddc1ffb757f826e3c3f2c38c4f sh smoketest.sh

Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good then, just needs a rebase.

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1423-48f2b2bac0d5e1aed413c790186be30e618c4f6a sh smoketest.sh

@andrewazores andrewazores merged commit 2ecf310 into cryostatio:main Mar 22, 2023
@andrewazores andrewazores deleted the agent-read-recordings branch March 22, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants