Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds have an incomplete version string #966

Open
ebaron opened this issue May 31, 2022 · 1 comment
Open

CI builds have an incomplete version string #966

ebaron opened this issue May 31, 2022 · 1 comment
Labels
bug Something isn't working ci

Comments

@ebaron
Copy link
Member

ebaron commented May 31, 2022

Our 2.1.0 release has 06a7974 listed for version as reported by Cryostat. I think there are a couple of problems here:

  1. The CI build does not fetch any tags when checking out the commit
  2. The CI build for the release occurs before the release is tagged
@ebaron
Copy link
Member Author

ebaron commented Jun 24, 2022

Our 2.1.0 release has 06a7974 listed for version as reported by Cryostat. I think there are a couple of problems here:

1. The CI build does not fetch any tags when checking out the commit

This should be fixable by adding fetch-depth: 0 to the checkout action.

2. The CI build for the release occurs before the release is tagged

The simplest solution here would probably be to re-run the workflow for the release event type, there might be a better solution though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
No open projects
Status: Pushed to Next Release
Status: Todo
Development

No branches or pull requests

1 participant