-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] AboutModal contains incorrect version of Cryostat #882
Comments
https://github.com/cryostatio/cryostat/blob/32870ff560342ebbc13862b97f304858470186a7/pom.xml#L407 Looks like this command invocation isn't returning the expected result. This gets output into a file at build time, which is packaged into the container image and what the health handler reads from for that response. I think downstream product builds have a correct version but it would be nice for upstream images and dev images to have something a little more concise (ie referring to a more recent tag). |
Possibly related: https://github.com/cryostatio/cryostat/issues/966 |
I think this happens because the I assume if we tag the main branches commits at the certain relevant release breakpoints, then it would return a 'correct' response. |
This is done for 2.3.0 now and has been documented as part of the release checklist. |
Current Behavior:
AboutModal contains a field
cryostatVersion
of 2.0.0-snapshot even though a development build of Cryostat should be of version2.3.0-snapshot
. I'm unaware of what it says for newer production images of Cryostat.Expected Behavior:
The
HealthGetHandler
to return a correct, updatedcryostatVersion
field.Is this something that should be fixed?
Screenshots
The text was updated successfully, but these errors were encountered: