Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] AboutModal contains incorrect version of Cryostat #882

Closed
maxcao13 opened this issue Feb 14, 2023 · 4 comments
Closed

[Question] AboutModal contains incorrect version of Cryostat #882

maxcao13 opened this issue Feb 14, 2023 · 4 comments
Labels
bug Something isn't working build

Comments

@maxcao13
Copy link
Member

Current Behavior:

AboutModal contains a field cryostatVersion of 2.0.0-snapshot even though a development build of Cryostat should be of version 2.3.0-snapshot. I'm unaware of what it says for newer production images of Cryostat.

Expected Behavior:

The HealthGetHandler to return a correct, updated cryostatVersion field.

Is this something that should be fixed?

Screenshots

image

@maxcao13 maxcao13 added question Further information is requested needs-triage Needs thorough attention from code reviewers labels Feb 14, 2023
@andrewazores
Copy link
Member

https://github.com/cryostatio/cryostat/blob/32870ff560342ebbc13862b97f304858470186a7/pom.xml#L407

Looks like this command invocation isn't returning the expected result. This gets output into a file at build time, which is packaged into the container image and what the health handler reads from for that response.

I think downstream product builds have a correct version but it would be nice for upstream images and dev images to have something a little more concise (ie referring to a more recent tag).

@andrewazores andrewazores added bug Something isn't working build and removed question Further information is requested needs-triage Needs thorough attention from code reviewers labels Feb 14, 2023
@ebaron
Copy link
Member

ebaron commented Feb 14, 2023

Possibly related: https://github.com/cryostatio/cryostat/issues/966

@maxcao13
Copy link
Member Author

I think this happens because the main branch of the cryostat repository is never tagged, and the production builds of cryostat are put into separate branches e.g. cryostat-v2.2 and those branch commits are tagged.

I assume if we tag the main branches commits at the certain relevant release breakpoints, then it would return a 'correct' response.

@andrewazores
Copy link
Member

#971 (comment)

This is done for 2.3.0 now and has been documented as part of the release checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants