Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Pluggable Discovery Microservices #940

Closed
2 of 3 tasks
Tracked by #936
andrewazores opened this issue May 13, 2022 · 1 comment
Closed
2 of 3 tasks
Tracked by #936

[Story] Pluggable Discovery Microservices #940

andrewazores opened this issue May 13, 2022 · 1 comment
Labels
feat New feature or request high-priority needs-documentation question Further information is requested ready-for-documentation

Comments

@andrewazores
Copy link
Member

andrewazores commented May 13, 2022

Parent: https://github.com/cryostatio/cryostat/issues/936
Depends on https://github.com/cryostatio/cryostat/issues/939
Depends on https://github.com/cryostatio/cryostat/issues/1049

Once we have an API designed for clients to provide environment and target node information to Cryostat, we should implement at least one such client ourselves as an optional microservice to deploy alongside Cryostat. The core functionalities of custom targets, JDP discovery, and OpenShift API (Endpoints and/or Annotations) should be included by default within the Cryostat deployment to minimize the footprint and maintenance burden but should be architected similarly to what we expect microservices to do, except running in-process (but still optional and enabled by environment variable(s)).

  • [Task] Document expected behaviour for microservices #1050
  • [Task] Implement a small example/template microservice (ex. for JDP) #1051
  • (Optional) Extract AbstractNode, EnvironmentNode, TargetNode, ServiceRef, and other relevant useful classes into -core for reuse by microservices implemented in JVM languages. (not strictly necessary, JVM services can avoid using -core so long as the serialized API responses have the correct fields, and same for non-JVM languages. But, for JVM languages, it would be nice to have for reuse to make implementation a little easier). Perhaps rather than -core this should be a separate interface/structs-only dependency to keep it small, ex. cryostat-discovery-api.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

This PR/issue depends on:

  • cryostatio/cryostat#939
  • cryostatio/cryostat#1049
    By Dependent Issues (🤖). Happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request high-priority needs-documentation question Further information is requested ready-for-documentation
Projects
No open projects
Status: In Progress
Status: Done
Development

No branches or pull requests

1 participant