-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): allow optional basic authentication #95
Conversation
Ahh upgrade tests failed:
|
Nicee! Fixed now^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than that minor docs comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thanks a lot @tthvo! This will be great for 2.4.
* feat(values): add authentication value parameters * feat(auth): implement basic authentication * fix(values): handle nullable cases * docs(readme): update to mention unset auth case (cherry picked from commit e6be8ea)
Yay I am very glad to help^^ |
* feat(values): add authentication value parameters * feat(auth): implement basic authentication * fix(values): handle nullable cases * docs(readme): update to mention unset auth case (cherry picked from commit e6be8ea)
* feat(values): add authentication value parameters * feat(auth): implement basic authentication * fix(values): handle nullable cases * docs(readme): update to mention unset auth case (cherry picked from commit e6be8ea)
* feat(values): add authentication value parameters * feat(auth): implement basic authentication * fix(values): handle nullable cases * docs(readme): update to mention unset auth case (cherry picked from commit e6be8ea) Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Fixes #4
What's new
Added some options for authentication (i.e. Basic Authentication) that are enabled on demand.
References
Ref: cryostatio/cryostat-operator#206 (comment)
Note: I added an additional
enabled
to make it more explicit to the user but let me know what u think.How to test
Create a secret (username:
user
and password:pass
):Create a chart release: