Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(multimodule): split out libcryostat module #423

Merged
merged 3 commits into from
Jul 18, 2024
Merged

chore(multimodule): split out libcryostat module #423

merged 3 commits into from
Jul 18, 2024

Conversation

andrewazores
Copy link
Member

Fixes #416

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere safe-to-test labels Jul 18, 2024
@andrewazores andrewazores mentioned this pull request Jul 18, 2024
Merged
@andrewazores
Copy link
Member Author

CI failure makes sense - quite a few classes got moved from cryostat-core into libcryostat. Most are directly moved with no functional changes but a few had some other minor changes, so all of the previous cryostat-core consumers are likely to need adjustments to import classes from libcryostat to compile again.

@andrewazores andrewazores marked this pull request as ready for review July 18, 2024 19:44
@andrewazores andrewazores requested a review from a team as a code owner July 18, 2024 19:44
ebaron
ebaron previously approved these changes Jul 18, 2024
View reviewed changes
aptmac
aptmac approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@aptmac aptmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

On another (but kind of related) note, it looks like rjmx.common and flightrecorder.configuration got uploaded to Maven Central, so the Adoptium repository can be removed from the poms. https://central.sonatype.com/namespace/org.openjdk.jmc

@andrewazores andrewazores merged commit a7813f8 into cryostatio:main Jul 18, 2024
7 of 8 checks passed
@andrewazores andrewazores deleted the multimodule branch July 18, 2024 20:39
This was referenced Jul 18, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptmac aptmac aptmac approved these changes

@ebaron ebaron ebaron left review comments

Assignees
No one assigned
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split implementations from interfaces and simple models
3 participants
@andrewazores @ebaron @aptmac