Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jsoup): remove useless Document type from method signature #403

Merged
merged 2 commits into from
Jun 3, 2024
Merged

chore(jsoup): remove useless Document type from method signature #403

merged 2 commits into from
Jun 3, 2024

Conversation

andrewazores
Copy link
Member

Related to cryostatio/cryostat#491
Related to #389

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Jun 3, 2024
@andrewazores andrewazores mentioned this pull request Jun 3, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-403-521c19a7c047e5a17ff95fec0db6926098de830a-linux-java17

To run smoketest:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-403-521c19a7c047e5a17ff95fec0db6926098de830a-linux-java17 bash smoketest.bash

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-403-a9cdb915d2338f3650fbb9c46a5b1a667a3bf46d-linux-java17

To run smoketest:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-403-a9cdb915d2338f3650fbb9c46a5b1a667a3bf46d-linux-java17 bash smoketest.bash

aali309
aali309 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 035e894 into cryostatio:main Jun 3, 2024
10 checks passed
@andrewazores andrewazores deleted the gh491 branch June 3, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @aali309