Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): remote readonly accesses #78

Merged
merged 11 commits into from
Mar 17, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Mar 15, 2023

Fixes #79
See https://github.com/cryostatio/cryostat/pull/1415

This does some refactoring, and then adds a capability for remote clients (the Cryostat server most likely) to retrieve select MBean metrics data over the HTTP API. This requires the same authentication as the discovery plugin flow.

@andrewazores andrewazores added the feat New feature or request label Mar 15, 2023
@andrewazores andrewazores changed the title feat(api): remote read access for MBeanMetrics feat(api): remote readonly accesses Mar 15, 2023
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as well too.

@andrewazores andrewazores merged commit 1b36a31 into cryostatio:main Mar 17, 2023
@andrewazores andrewazores deleted the read-mbeans branch March 17, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Expose readonly properties on HTTP API
2 participants