feat(tls): add configuration options for supplying bare TLS server key #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
added
feat
andrewazores
force-pushed
the
tls-server-key
branch
from
102d8eb
to
0ac4b31
Compare
|
I tried to mimic the "bare key file" approach that I did for client authentication, but hook it in to the existing webserver HTTPS setup. The keystore file can be provided alone, or the bare key can be provided alone in which case a new empty keystore is generated to contain it. If both are specified then the keystore file will be loaded, then the additional bare key will be inserted into it. I haven't actually tested this yet. |
ebaron
approved these changes
Oct 22, 2024
andrewazores
force-pushed
the
tls-server-key
branch
from
0ac4b31
to
e7f01d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #491
See #491 (review)