Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(image): add Dockerfile for agent carrier container image #390

Merged
merged 13 commits into from
Jul 12, 2024
Merged

build(image): add Dockerfile for agent carrier container image #390

merged 13 commits into from
Jul 12, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 26, 2024 •
edited
Loading

Related to #233
See cryostatio/test-applications#6 (replaces Quarkus test build from this repo)

$ podman build . -f src/main/container/Containerfile -t quay.io/cryostat/cryostat-agent-carrier:latest

@andrewazores andrewazores added build safe-to-test ci feat New feature or request and removed ci labels Apr 26, 2024
@andrewazores andrewazores marked this pull request as ready for review July 9, 2024 19:14
@andrewazores andrewazores requested a review from ebaron July 9, 2024 19:14
@andrewazores andrewazores mentioned this pull request Jul 9, 2024
Closed
ebaron
ebaron reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. What about using the name cryostat-agent-init instead of carrier to make it clear that this is to be used as an init container only?

src/main/container/Containerfile Outdated Show resolved Hide resolved
@andrewazores andrewazores changed the title build(image): add Containerfile for agent carrier container image build(image): add Dockerfile for agent carrier container image Jul 12, 2024
@andrewazores andrewazores merged commit 8878d38 into cryostatio:main Jul 12, 2024
11 checks passed
@andrewazores andrewazores deleted the carrier-image branch July 12, 2024 22:07
This was referenced Jul 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
build feat New feature or request safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @ebaron