Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump com.redhat.insights:runtimes-agent from 0.9.0 to 0.9.1 #281

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2023

Bumps com.redhat.insights:runtimes-agent from 0.9.0 to 0.9.1.

Release notes

Sourced from com.redhat.insights:runtimes-agent's releases.

Release 0.9.1

Changelog

88d6402 Releasing version 0.9.1 30eb0ac Bump client versin (#18) a3951d7 Filter shade.prefix in simplelogger.properties (#17) 4f9b941 Use SLF4J, avoid interfering with application logging (#15) 793476d Fix token detection (#16) c837312 Setting version 0.9.1-SNAPSHOT

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.redhat.insights:runtimes-agent](https://github.com/RedHatInsights/insights-java-agent) from 0.9.0 to 0.9.1.
- [Release notes](https://github.com/RedHatInsights/insights-java-agent/releases)
- [Commits](RedHatInsights/insights-java-agent@0.9.0...0.9.1)

---
updated-dependencies:
- dependency-name: com.redhat.insights:runtimes-agent
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner December 1, 2023 14:56
@dependabot dependabot bot added chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test labels Dec 1, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Dec 1, 2023
@andrewazores andrewazores added backport and removed needs-triage Needs thorough attention from code reviewers labels Dec 4, 2023
@andrewazores
Copy link
Member

@ebaron we want this for 2.4.1, right?

@ebaron
Copy link
Member

ebaron commented Dec 8, 2023

@ebaron we want this for 2.4.1, right?

We do, thanks

ebaron
ebaron previously approved these changes Dec 8, 2023
@andrewazores
Copy link
Member

 Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project cryostat-agent: Compilation failure: Compilation failure: 
Error:  /home/runner/work/cryostat-agent/cryostat-agent/src/main/java/io/cryostat/agent/insights/InsightsAgentHelper.java:[92,60] error: method of in class AgentBasicReport cannot be applied to given types;
Error:    required: InsightsConfiguration
Error:    found: InsightsLogger,AgentConfiguration
Error:    reason: actual and formal argument lists differ in length
Error:  /home/runner/work/cryostat-agent/cryostat-agent/src/main/java/io/cryostat/agent/insights/InsightsAgentHelper.java:[96,22] error: constructor InsightsAgentHttpClient in class InsightsAgentHttpClient cannot be applied to given types;
Error:    required: InsightsConfiguration,Supplier<SSLContext>
Error:    found: InsightsLogger,AgentConfiguration,()->pem.cr[...]ext()
Error:    reason: actual and formal argument lists differ in length
Error:  /home/runner/work/cryostat-agent/cryostat-agent/src/main/java/io/cryostat/agent/insights/InsightsAgentHelper.java:[104,31] error: constructor ClassNoticer in class ClassNoticer cannot be applied to given types;
Error:    required: BlockingQueue<JarInfo>
Error:    found: InsightsLogger,BlockingQueue<JarInfo>
Error:    reason: actual and formal argument lists differ in length
Error:  -> [Help 1]

Insights changed some signatures on a bugfix release, I guess. Needs some patching.

@ebaron
Copy link
Member

ebaron commented Dec 8, 2023

 Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project cryostat-agent: Compilation failure: Compilation failure: 
Error:  /home/runner/work/cryostat-agent/cryostat-agent/src/main/java/io/cryostat/agent/insights/InsightsAgentHelper.java:[92,60] error: method of in class AgentBasicReport cannot be applied to given types;
Error:    required: InsightsConfiguration
Error:    found: InsightsLogger,AgentConfiguration
Error:    reason: actual and formal argument lists differ in length
Error:  /home/runner/work/cryostat-agent/cryostat-agent/src/main/java/io/cryostat/agent/insights/InsightsAgentHelper.java:[96,22] error: constructor InsightsAgentHttpClient in class InsightsAgentHttpClient cannot be applied to given types;
Error:    required: InsightsConfiguration,Supplier<SSLContext>
Error:    found: InsightsLogger,AgentConfiguration,()->pem.cr[...]ext()
Error:    reason: actual and formal argument lists differ in length
Error:  /home/runner/work/cryostat-agent/cryostat-agent/src/main/java/io/cryostat/agent/insights/InsightsAgentHelper.java:[104,31] error: constructor ClassNoticer in class ClassNoticer cannot be applied to given types;
Error:    required: BlockingQueue<JarInfo>
Error:    found: InsightsLogger,BlockingQueue<JarInfo>
Error:    reason: actual and formal argument lists differ in length
Error:  -> [Help 1]

Insights changed some signatures on a bugfix release, I guess. Needs some patching.

I've fixed things up, mind taking a look?

@ebaron ebaron merged commit e6d0884 into main Dec 8, 2023
10 checks passed
@andrewazores
Copy link
Member

Looks alright to me - I don't really know what changed on the Insights side, but from our side that looks pretty good.

@dependabot dependabot bot deleted the dependabot/maven/com.redhat.insights-runtimes-agent-0.9.1 branch December 8, 2023 21:50
mergify bot pushed a commit that referenced this pull request Dec 8, 2023
…9.1 (#281)

* build(deps): bump com.redhat.insights:runtimes-agent from 0.9.0 to 0.9.1

Bumps [com.redhat.insights:runtimes-agent](https://github.com/RedHatInsights/insights-java-agent) from 0.9.0 to 0.9.1.
- [Release notes](https://github.com/RedHatInsights/insights-java-agent/releases)
- [Commits](RedHatInsights/insights-java-agent@0.9.0...0.9.1)

---
updated-dependencies:
- dependency-name: com.redhat.insights:runtimes-agent
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix conflicts

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elliott Baron <ebaron@redhat.com>
(cherry picked from commit e6d0884)

# Conflicts:
#	pom.xml
ebaron added a commit that referenced this pull request Dec 8, 2023
…9.1 (backport #281) (#298)

* build(deps): bump com.redhat.insights:runtimes-agent from 0.9.0 to 0.9.1 (#281)

* build(deps): bump com.redhat.insights:runtimes-agent from 0.9.0 to 0.9.1

Bumps [com.redhat.insights:runtimes-agent](https://github.com/RedHatInsights/insights-java-agent) from 0.9.0 to 0.9.1.
- [Release notes](https://github.com/RedHatInsights/insights-java-agent/releases)
- [Commits](RedHatInsights/insights-java-agent@0.9.0...0.9.1)

---
updated-dependencies:
- dependency-name: com.redhat.insights:runtimes-agent
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix conflicts

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elliott Baron <ebaron@redhat.com>
(cherry picked from commit e6d0884)

# Conflicts:
#	pom.xml

* Fix conflicts in pom.xml

Signed-off-by: Elliott Baron <ebaron@redhat.com>

---------

Signed-off-by: Elliott Baron <ebaron@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elliott Baron <ebaron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants