Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smart_triggers): add test case for single-quoted duration #276

Merged

Conversation

andrewazores
Copy link
Member

Related to #253

Adds one extra test case to ensure that the duration() syntax accepts single-quoted values. This can be useful when deploying the Agent so the user has flexibility on where to use single and double quotes to avoid having to use escape sequences while still being able to use whitespace, or perhaps even variable interpolations, etc.

The implementation already handles this case so this is simply adding a test to catch any future regressions.

Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewazores andrewazores merged commit f189a65 into cryostatio:main Nov 29, 2023
10 checks passed
@andrewazores andrewazores deleted the trigger-test-single-quote branch November 29, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants