-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(credentials): store credentials with unique matchExpression #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Is it me, or do I still see the old format: It should be both connectUrl + jvmId? These are quarkus-test:latest images I built from the PR. Are these steps still applicable?
|
In the |
Hm... I still can't seem to figure it out, but if other people's are working than it probably is something I'm else I'm missing. |
* fix(credentials): store credentials with expr matching callback and jvmId * generate UUID for instance, include in alias/realm as well as platform annotation * do not try to delete credentials if they have not yet been submitted * document new config * fix incorrect doc description (cherry picked from commit 09987e0)
#160) * fix(credentials): store credentials with expr matching callback and jvmId * generate UUID for instance, include in alias/realm as well as platform annotation * do not try to delete credentials if they have not yet been submitted * document new config * fix incorrect doc description (cherry picked from commit 09987e0) Co-authored-by: Andrew Azores <aazores@redhat.com>
I figured out the problem. I was running |
Fixes #154