fix(credentials): store credentials with unique matchExpression

[andrewazores]

Fixes #154

[tthvo]

Looks good to me!

[tthvo]

Looks good to me!

[maxcao13]

Is it me, or do I still see the old format:

It should be both connectUrl + jvmId? These are quarkus-test:latest images I built from the PR.

Are these steps still applicable?

# cryostat-agent
mvn -DskipTests -Dspotless.check.skip install
cd ../quarkus-test
./mvnw -DskipTests -U package && podman build -t quay.io/andrewazores/quarkus-test:latest -f src/main/docker/Dockerfile.jvm .

[andrewazores]

In the smoketest.sh there are quarkus-test and vertx-fib-demo that both have Cryostat Agent instances on them, so both of those container images would need to be updated to include these changes. There are three of the vertx-fib-demos so that probably matches the three old-style credentials you're seeing.

[tthvo]

Just wondering it is also because the database is not pruned off those entries? I am seeing all formats.

Now that its noticed. Users that use the agent should probably be informed about this change and remove previous stored credentials???

[maxcao13]

In the smoketest.sh there are quarkus-test and vertx-fib-demo that both have Cryostat Agent instances on them, so both of those container images would need to be updated to include these changes. There are three of the vertx-fib-demos so that probably matches the three old-style credentials you're seeing.

Hm... I still can't seem to figure it out, but if other people's are working than it probably is something I'm else I'm missing.

[maxcao13]

I figured out the problem. I was running sh smoketest.sh right after a mvn clean package in the base cryostat and I realized that the package lifecycle no longer builds an image with the tag 2.4.0-snapshot anymore, and that's what run.sh defaults to based on the pom.xml if CRYOSTAT_IMAGE isn't set.