Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Locale "en" for groups in archives #17

Merged
merged 1 commit into from
Nov 19, 2014
Merged

Adds Locale "en" for groups in archives #17

merged 1 commit into from
Nov 19, 2014

Conversation

dl1ely
Copy link
Contributor

@dl1ely dl1ely commented Nov 19, 2014

MMMM in the SimpleDateFormat constructor is replaced with the month name
of the default locale. The date:longDate filter of Selmer in Archives.html
generates a format with english month names. On non-english Systems that
leads to months names in the local language for the group names, but
english month names for the full dates on the post. To be consistent, the
locale "en" gets set manually on the SimpleDateFormatter constructor call.
This results in english month names on the archives page.

Fixes #16

MMMM in the SimpleDateFormat constructor is replaced with the month name
of the default locale. The date:longDate filter of Selmer in Archives.html
generates a format with english month names. On non-english Systems that
leads to months names in the local language for the group names, but
english month names for the full dates on the post. To be consistent, the
locale "en" gets set manually on the SimpleDateFormatter constructor call.
This results in english month names on the archives page.
yogthos added a commit that referenced this pull request Nov 19, 2014
Adds Locale "en" for groups in archives
@yogthos yogthos merged commit 99f7fc8 into cryogen-project:master Nov 19, 2014
@lacarmen
Copy link
Member

@dl1ely I've pushed out a new template to clojars with your changes and latest Selmer :)

@dl1ely
Copy link
Contributor Author

dl1ely commented Nov 19, 2014

I will work on making locale configurable in cryogen instead of using "en" fix. Now that Selmer supports those locales they can be made configurable in cryogen, too. We also need not only locales for month names, but also locale dependant format strings. German date format is different in order from the U.S. one. I will look into this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language mismatch in date on archives page
3 participants