-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new entries - Zyte, Devtron, Openreplay, Stepzen, Dyrectorio, Docker #668
Conversation
docs/list.md
Outdated
- Should be eligible for official hacktoberfest, other than that no special requirement. | ||
- **Issues**: | ||
- Find all the open source repo issues [in this StepZen GitHub project view here.](https://github.com/stepzen-dev/examples/issues). | ||
- **Notes**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docs/list.md
Outdated
- Check the list of open sourec repos by Zyte [here](https://www.zyte.com/blog/hacktoberfest-2022/) | ||
- **Notes**: | ||
- You only need to fill [this]() form after one of your pull requests is accepted. | ||
- Check out the [blog post](https://www.zyte.com/blog/hacktoberfest-2022) for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing punctuation in header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DId not get this. Please help in understanding
👇 Click on the image for a new way to code review
Legend |
✅ Deploy Preview for hacktoberfest-swag-list ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @crweiner . I have added & updated the above changes in the PR. Looking forward to hear from you. Thanks |
Hey @Ruchika30 thank you for contribution.👏 The netlify bot has generated a deploy preview take a look at it and you will notice indentation issues for the items you submitted. If there isn't a list, you don't need to break it out on the next line. Look at the other submitted items, you will get the idea of the expected formatting. The Notes section is a note for the reader to something be aware of so that their contribution is valuable and meaningful to the company. It's not required that everything you add in there has to come from the announcement, feel free to paraphrase or post a small summary of what you gather from the provided information. The prize list for Devtron is already revealed. You don't need to list all of them individually but it would be nice to list the category they are like Swag Kit, Stickers,,etc. go through all of them once you will get the idea of what to add in the Swag section. The details of Docker can also include about the two ways they can contribute to the Docker extension, and the link they provide for all available extensions which one can contribute to. In the Zyte, update the swag, you accidentally added Hacktoberfest swag. You could also add the repos one is expected to contribute to. And you forgot to add the link to their form, or you can skip over the Notes a you have added that part in the Requirements section. I would advice go through all details once again carefully and patiently to make a meaningful contribution. And if it too overwhelming or if you feel stuck or need help with something, feel free to ask. |
Hello @vimode and @Ruchika30! Thank you @vimode for the through review. 🤝 You're absolutely correct, and I would appreciate if @Ruchika30 could make those changes. If you'd like to submit a line-by-line review formally, let me know! |
Yes. I am on it @crweiner Thanks for the review |
docs/list.md
Outdated
@@ -197,6 +197,50 @@ Appwrite is a self-hosted backend-as-a-service platform that provides developers | |||
- **How to sign up**: Sign in with [Github here](https://devict-hacktoberfest.herokuapp.com/) so they can track your PRs. | |||
- **Notes**: You need to create at least two PRs in any of the Wichita developer community organizations listed [here](https://devict-hacktoberfest.herokuapp.com/) | |||
|
|||
#### **Devtron** | |||
|
|||
- **Swag**: Swag Kit, Raspberry Pi 4, SAMSUNG Galaxy Tab A8, Google Home Mini with Google Assistant Smart Speaker, Surprize Box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docs/list.md
Outdated
|
||
- **Swag**: Swag Kit, Raspberry Pi 4, SAMSUNG Galaxy Tab A8, Google Home Mini with Google Assistant Smart Speaker, Surprize Box. | ||
- **Requirements**: | ||
- Under [Devtron-labs](https://github.com/devtron-labs) there are multiple repositories that hold some part of the code that goes into making Devtron what it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docs/list.md
Outdated
@@ -197,6 +197,49 @@ Appwrite is a self-hosted backend-as-a-service platform that provides developers | |||
- **How to sign up**: Sign in with [Github here](https://devict-hacktoberfest.herokuapp.com/) so they can track your PRs. | |||
- **Notes**: You need to create at least two PRs in any of the Wichita developer community organizations listed [here](https://devict-hacktoberfest.herokuapp.com/) | |||
|
|||
#### **Devtron** | |||
- **Swag**: Swag Kit, Raspberry Pi 4, SAMSUNG Galaxy Tab A8, Google Home Mini with Google Assistant Smart Speaker, Surprize Box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
@@ -197,6 +197,49 @@ Appwrite is a self-hosted backend-as-a-service platform that provides developers | |||
- **How to sign up**: Sign in with [Github here](https://devict-hacktoberfest.herokuapp.com/) so they can track your PRs. | |||
- **Notes**: You need to create at least two PRs in any of the Wichita developer community organizations listed [here](https://devict-hacktoberfest.herokuapp.com/) | |||
|
|||
#### **Devtron** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Headers should be surrounded by blank lines
docs/list.md
Outdated
@@ -197,6 +197,49 @@ Appwrite is a self-hosted backend-as-a-service platform that provides developers | |||
- **How to sign up**: Sign in with [Github here](https://devict-hacktoberfest.herokuapp.com/) so they can track your PRs. | |||
- **Notes**: You need to create at least two PRs in any of the Wichita developer community organizations listed [here](https://devict-hacktoberfest.herokuapp.com/) | |||
|
|||
#### **Devtron** | |||
- **Swag**: Swag Kit, Raspberry Pi 4, SAMSUNG Galaxy Tab A8, Google Home Mini with Google Assistant Smart Speaker, Surprize Box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
Code Climate has analyzed commit 0afa71c and detected 0 issues on this pull request. View more on Code Climate. |
Hi again @Ruchika30! 👋 Thank you for your PR to add lots of companies to the Swag List! I've had to do several big adjustments to this PR, more than I would normally do, but I wanted to make sure that these organizations can get on the Swag List ASAP. Please be sure to follow the Contributing guide more closely next time. 👍 Thank you for your time and effort in putting all of this together, and I hope you have a great Hacktoberfest! 🎃 |
Thanks @crweiner .Sorry that you had to make lots of edits |
|
Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:
Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀