Skip to content

Conversation

@malouro
Copy link
Contributor

@malouro malouro commented May 30, 2025

What:

Adds a period (".") into the current user-event keyboard map.

Why:

Currently, the following code produces unexpected results:

userEvent.keyboard('user@email.com');

outputs the following into the console:

user@emailUnknowncom

How:

Updated the defaultKeyMap to contain a value for . (\x2e hex code)

Checklist:

  • Tests (N\A)
  • TypeScript definitions updated (N\A)
  • Ready to be merged

(I believe it's unnecessary to update tests for this as I didn't see existing specs that covered this keyMap, but correct me if I'm wrong)

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 31, 2025

Open in StackBlitz

npm i https://pkg.pr.new/cli-testing-library@40

commit: 8933689

@malouro
Copy link
Contributor Author

malouro commented Jun 11, 2025

Hey @crutchcorn, can this be merged or did you need something more before merging?

@malouro malouro closed this Sep 14, 2025
@malouro malouro reopened this Sep 14, 2025
@crutchcorn
Copy link
Owner

Whoops. Sorry, this LGTM. Let me run CI/CD real fast

@crutchcorn crutchcorn merged commit 566d57e into crutchcorn:main Sep 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants