Hide badge if component.badgable is false. Fixes GrapesJS#5340

crupko93 · Aug 30, 2023 · 0315af8 · 0315af8
1 parent 945156a
commit 0315af8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/commands/view/SelectComponent.ts b/src/commands/view/SelectComponent.ts
@@ -332,8 +332,13 @@ export default {
   updateBadge(el: HTMLElement, pos: any, opts: any = {}) {
     const { canvas } = this;
     const model = getComponentModel(el);
-    if (!model || !model.get('badgable')) return;
     const badge = this.getBadge(opts);
+    const bStyle = badge.style;
+
+    if (!model || !model.get('badgable')) {
+      bStyle.display = 'none';
+      return;
+    }
 
     if (!opts.posOnly) {
       const config = this.canvas.getConfig();
@@ -347,7 +352,6 @@ export default {
     }
 
     const un = 'px';
-    const bStyle = badge.style;
     bStyle.display = 'block';
 
     const targetToElem = canvas.getTargetToElementFixed(el, badge, {