Harmonize CI workflow #57
Conversation
| pull_request: | ||
| branches: | ||
| - '3.5' |
There was a problem hiding this comment.
Prevent double runs for PR-s.
There was a problem hiding this comment.
Do i need to change it when i add new "main" branch?
There was a problem hiding this comment.
What about bugfixes that will target 3.4 branch?
There was a problem hiding this comment.
All supported branches should be listed here.
There was a problem hiding this comment.
But this CI configuration will not run on old branches.
I've meant it will fail because of Symfony versions.
There was a problem hiding this comment.
No, only on the branches listed above. What branches should I add?
Please add 3.5 and 3.6, hold on with rebase until I release v3.5.
There was a problem hiding this comment.
https://github.com/crunzphp/crunz/releases/tag/v3.5.0 released, so You can rebase :)
| concurrency: | ||
| group: '${{ github.workflow }}-${{ github.ref }}' | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Cancel earlier runs.
| - uses: ramsey/composer-install@v2 | ||
| with: | ||
| dependency-versions: ${{ matrix.dependencies }} | ||
| composer-options: '--with=symfony/console:${{ matrix.symfony_version }}' |
There was a problem hiding this comment.
Use Ben's excellent action: cache+install
|
|
||
| name: Static analysis | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Upgrade all actions.
| @@ -0,0 +1,107 @@ | |||
| name: PHP | |||
There was a problem hiding this comment.
New name! 🎉
May I add a spellcheck workflow? #56
There was a problem hiding this comment.
Okay. In the next PR.
composer.json
Outdated
| "symfony/mailer": "^5.4.9 || ^6.0.9", | ||
| "symfony/process": "^5.4.9 || ^6.0.9", | ||
| "symfony/yaml": "^5.4.9 || ^6.0.9" | ||
| "symfony/config": "^5.4.9 || ^6.0.9 || ^6.1.0 || ^6.2.0", |
There was a problem hiding this comment.
There is no need to add ^6.1.0 || ^6.2.0, ^6.0.9 is enough.
|
Please don't care about the static analysis error in this PR. |
|
CI fails, because You changed Symfony version to |
Done. |
|
Oh no! 6.1 support ended. Line 43 in 8491550 |
|
I had to hire a DEVELOPER 🤯 |
| php: | ||
| - '8.0' | ||
| - '8.1' | ||
| - '8.2' |
|
Thanks @szepeviktor |
| - uses: ramsey/composer-install@v2 | ||
| with: | ||
| dependency-versions: ${{ matrix.dependencies }} | ||
| composer-options: '--with=symfony/console:${{ matrix.symfony_version }}' |
There was a problem hiding this comment.
It's already merged, but looks like this will install only symfony/console in expected version, not all symfony dependencies.
There was a problem hiding this comment.
Composer is smart enough to match versions of other Symfony pkgs
There was a problem hiding this comment.
No.
- Locking symfony/config (v6.3.2)
- Locking symfony/console (v5.4.28) 👈🏻
- Locking symfony/dependency-injection (v6.3.5)
- Locking symfony/deprecation-contracts (v3.3.0)
- Locking symfony/error-handler (v6.3.5)
- Locking symfony/event-dispatcher (v6.3.2)
- Locking symfony/event-dispatcher-contracts (v3.3.0)
- Locking symfony/filesystem (v6.3.1)
- Locking symfony/finder (v6.3.5)
- Locking symfony/lock (v6.3.2)
- Locking symfony/mailer (v6.3.5)
- Locking symfony/mime (v6.3.5)
All others are at 6.3
There was a problem hiding this comment.
I never thought a 5.4 Symfony pkg is compatible with other 6.3 ones.
There was a problem hiding this comment.
Told You :) Looks like custom composer-install.php should be reverted.
There was a problem hiding this comment.
I should come up with a tiny and effective solution in minutes 🕦
Improve every line in the workflow.
@PabloKowalczyk Please do squash my commits.