Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS classes for jQuery click binding do not work for Django 2.1.3 #247

Closed
nwp90 opened this issue Mar 13, 2019 · 6 comments · Fixed by #257
Closed

CSS classes for jQuery click binding do not work for Django 2.1.3 #247

nwp90 opened this issue Mar 13, 2019 · 6 comments · Fixed by #257

Comments

@nwp90
Copy link
Contributor

nwp90 commented Mar 13, 2019

It seems that .inline-group now needs to be ._inline-group, in static/ajax_select/js/ajax_select.js line 243 (with Django 2.1.3) - otherwise #157 is back.
nwp90 added a commit to nwp90/django-ajax-selects that referenced this issue Mar 13, 2019
@nwp90
Fix for crucialfelix (upstream) github issue crucialfelix#247
2de0aaa
@crucialfelix
Copy link
Owner

If you can post a quick PR for that it would be splendid. Just add both the old and new classes and it will work for everybody.

Thanks !

@crucialfelix crucialfelix changed the title #157 is back CSS classes for jQuery click binding do not work for Django 2.1.3 Apr 4, 2019
nwp90 added a commit to nwp90/django-ajax-selects that referenced this issue Feb 4, 2020
@nwp90
Fix for crucialfelix (upstream) github issue crucialfelix#247
a75f7e6
@nwp90 nwp90 mentioned this issue Feb 4, 2020
Merged
@nwp90
Copy link
Contributor Author

nwp90 commented Feb 4, 2020

Haven't retested the fix yet; am doing so now.

@nwp90
Copy link
Contributor Author

nwp90 commented Feb 4, 2020

Oops, don't think I left the old class in...

nwp90 added a commit to nwp90/django-ajax-selects that referenced this issue Feb 5, 2020
@nwp90
Fix for crucialfelix (upstream) github issue crucialfelix#247
098fe4f
@nwp90
Copy link
Contributor Author

nwp90 commented Feb 5, 2020

Added back the original classes, testing now.

@nwp90
Copy link
Contributor Author

nwp90 commented Feb 10, 2020

Seems good with current Django, haven't tested with old Django version.

crucialfelix added a commit that referenced this issue Feb 11, 2020
@crucialfelix
Merge pull request #257 from nwp90/nwp
cc5b136 
Fix #247 CSS classes for jQuery click binding do not work for Django 2.1.3
@crucialfelix
Copy link
Owner

Release 1.9.1
https://pypi.org/project/django-ajax-selects/
Thanks again for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #247 CSS classes for jQuery click binding do not work for Django 2.1.3 nwp90/django-ajax-selects
2 participants
@nwp90 @crucialfelix