Skip to content

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 13, 2025

  • simplify and centralize the set up of subloggers
  • add "method" field to each sublogger
  • define common interface for Logger and Entry with Trace/Tracef methods (FieldLogger does not have them)
  • add support for syslog output

@mmetc mmetc added this to the 1.7.4 milestone Nov 13, 2025
@mmetc mmetc added the kind/enhancement New feature or request label Nov 13, 2025
@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 64.36364% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.72%. Comparing base (f2a4aef) to head (c901213).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/logging/syslog.go 0.00% 30 Missing ⚠️
cmd/crowdsec/flags.go 68.75% 14 Missing and 1 partial ⚠️
cmd/crowdsec/main.go 56.00% 9 Missing and 2 partials ⚠️
pkg/logging/standard.go 70.83% 7 Missing ⚠️
pkg/csplugin/hclog_adapter.go 25.00% 6 Missing ⚠️
cmd/crowdsec/run_in_svc_windows.go 0.00% 5 Missing ⚠️
pkg/apiserver/apiserver.go 50.00% 4 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clipapi/papi.go 33.33% 4 Missing ⚠️
cmd/crowdsec/win_service.go 0.00% 4 Missing ⚠️
cmd/crowdsec-cli/clinotifications/notifications.go 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4045      +/-   ##
==========================================
- Coverage   62.74%   62.72%   -0.02%     
==========================================
  Files         459      464       +5     
  Lines       33067    33047      -20     
==========================================
- Hits        20747    20728      -19     
- Misses      10197    10214      +17     
+ Partials     2123     2105      -18     
Flag Coverage Δ
bats 46.29% <60.98%> (-0.08%) ⬇️
unit-linux 35.35% <19.31%> (-0.10%) ⬇️
unit-windows 24.75% <14.04%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as ready for review November 13, 2025 14:28
@mmetc mmetc requested a review from blotus November 13, 2025 14:28
@mmetc mmetc marked this pull request as draft November 17, 2025 13:43
@mmetc mmetc marked this pull request as ready for review November 21, 2025 09:50
@mmetc mmetc merged commit 58c2147 into master Nov 26, 2025
16 checks passed
@mmetc mmetc deleted the log-mode-syslog branch November 26, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request needs/area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants