Skip to content

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 5, 2025

No description provided.

@mmetc mmetc added this to the 1.7.4 milestone Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from blotus November 5, 2025 14:58
@mmetc mmetc marked this pull request as draft November 5, 2025 14:59
@mmetc mmetc added the kind/enhancement New feature or request label Nov 5, 2025
@mmetc mmetc changed the title pkg/acquisition: refact journalctl datasource and upstream retry loop pkg/acquisition: refact journalctl datasource and unified retry loop Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 69.79592% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.62%. Comparing base (a6b61ed) to head (128486f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/acquisition.go 37.50% 29 Missing and 1 partial ⚠️
pkg/acquisition/modules/journalctl/run.go 72.16% 19 Missing and 8 partials ⚠️
pkg/acquisition/modules/journalctl/metrics.go 0.00% 6 Missing ⚠️
pkg/acquisition/modules/journalctl/source.go 64.70% 6 Missing ⚠️
pkg/acquisition/modules/journalctl/config.go 93.22% 2 Missing and 2 partials ⚠️
pkg/cticlient/ctiexpr/expr.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4023      +/-   ##
==========================================
- Coverage   62.67%   62.62%   -0.05%     
==========================================
  Files         416      420       +4     
  Lines       32962    33016      +54     
==========================================
+ Hits        20658    20677      +19     
- Misses      10180    10213      +33     
- Partials     2124     2126       +2     
Flag Coverage Δ
bats 46.31% <15.91%> (-0.07%) ⬇️
unit-linux 35.29% <65.71%> (-0.02%) ⬇️
unit-windows 24.70% <11.02%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as ready for review November 5, 2025 20:50
@mmetc mmetc merged commit 6a5e3a0 into master Nov 7, 2025
16 checks passed
@mmetc mmetc deleted the ctx-journalctl branch November 7, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request needs/area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants