Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core dependency to Logs module. #130

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

serhii-londar
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #130 (281a24f) into master (1f9bf36) will increase coverage by 0.02%.
The diff coverage is 63.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   49.73%   49.74%   +0.02%     
==========================================
  Files         122      122              
  Lines        4738     4729       -9     
==========================================
- Hits         2356     2352       -4     
+ Misses       2382     2377       -5     
Impacted Files Coverage Δ
...nSDK/Logs/Attributes/AttributedTextFormatter.swift 97.44% <ø> (ø)
...asses/CrowdinSDK/Logs/CrowdinSDKConfig+Debug.swift 28.58% <ø> (ø)
...rowdinSDK/Classes/CrowdinSDK/Logs/CrowidnLog.swift 30.77% <ø> (ø)
...s/CrowdinSDK/Logs/Extensions/Data+Extensions.swift 100.00% <ø> (ø)
...Classes/CrowdinSDK/Logs/CrowdinLogsCollector.swift 53.34% <53.34%> (ø)
...ContentDeliveryAPI/CrowdinContentDeliveryAPI.swift 56.31% <100.00%> (ø)
.../CrowdinSDK/Logs/Attributes/AttributeFactory.swift 100.00% <100.00%> (ø)
...dinSDK/Classes/CrowdinSDK/Logs/CrowdinAPILog.swift 100.00% <100.00%> (ø)
...SDK/Classes/CrowdinSDK/Extensions/Dictionary.swift 50.00% <0.00%> (-7.69%) ⬇️
Tests/Pods/BaseAPI/BaseAPI/Classes/Request.swift 96.67% <0.00%> (-3.33%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9bf36...281a24f. Read the comment docs.

Move all logging functionality to Core.
@crowdin-bot
Copy link
Collaborator

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 281a24f

@andrii-bodnar andrii-bodnar merged commit a49b10b into master Apr 9, 2021
@andrii-bodnar andrii-bodnar deleted the dependency-fixes-for-1.2.1 branch April 9, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants