Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few improvements for code structure #129

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

NazarYavornytskyy
Copy link
Contributor

@serhii-londar Please review and tell me if all is fine now

@crowdin-bot
Copy link
Collaborator

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 45d38be

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #129 (45d38be) into master (9b3a766) will increase coverage by 0.03%.
The diff coverage is 71.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   49.69%   49.71%   +0.03%     
==========================================
  Files         122      122              
  Lines        4742     4738       -4     
==========================================
- Hits         2356     2355       -1     
+ Misses       2386     2383       -3     
Impacted Files Coverage Δ
...CrowdinSDK/Utils/Attributes/AttributeFactory.swift 100.00% <ø> (ø)
...r/Operations/CrowdinStringsDownloadOperation.swift 68.75% <ø> (+10.86%) ⬆️
CrowdinSDK/Classes/CrowdinAPI/CrowdinAPI.swift 53.27% <50.00%> (ø)
...ContentDeliveryAPI/CrowdinContentDeliveryAPI.swift 56.31% <100.00%> (ø)
...SDK/Utils/Attributes/AttributedTextFormatter.swift 97.44% <100.00%> (ø)
...owdinSDK/Classes/Features/Logs/CrowdinAPILog.swift 70.59% <100.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3a766...45d38be. Read the comment docs.

@andrii-bodnar andrii-bodnar merged commit 1f9bf36 into master Apr 5, 2021
@andrii-bodnar andrii-bodnar deleted the 172_obtain_sdk_logs_improvements branch April 5, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants