Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move manifest error notification to CrowdinProvider/Core subspec. #119

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

serhii-londar
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #119 (66dc656) into master (309511c) will increase coverage by 0.01%.
The diff coverage is 57.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   48.80%   48.80%   +0.01%     
==========================================
  Files         117      117              
  Lines        4558     4562       +4     
==========================================
+ Hits         2224     2226       +2     
- Misses       2334     2336       +2     
Impacted Files Coverage Δ
...tionDownloader/CrowdinLocalizationDownloader.swift 63.22% <0.00%> (-2.25%) ⬇️
...ContentDeliveryAPI/CrowdinContentDeliveryAPI.swift 51.86% <60.00%> (-0.44%) ⬇️
...ders/Crowdin/ManifestManager/ManifestManager.swift 100.00% <100.00%> (ø)
Tests/Pods/BaseAPI/BaseAPI/Classes/BaseAPI.swift 25.52% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309511c...66dc656. Read the comment docs.

@andrii-bodnar andrii-bodnar merged commit 227d49d into master Mar 2, 2021
@andrii-bodnar andrii-bodnar deleted the manifest-error-notification branch March 2, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants