Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two_letters_code export pattern #114

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

NazarYavornytskyy
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #114 (5203b05) into master (36f1487) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   50.39%   50.54%   +0.16%     
==========================================
  Files         118      118              
  Lines        4551     4567      +16     
==========================================
+ Hits         2293     2308      +15     
- Misses       2258     2259       +1     
Impacted Files Coverage Δ
...viders/Crowdin/PathParser/CrowdinPathsParser.swift 100.00% <100.00%> (ø)
...ests/CrowdinProvider/CrowdinPathsParserTests.swift 100.00% <100.00%> (ø)
Tests/Pods/BaseAPI/BaseAPI/Classes/BaseAPI.swift 24.49% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d13c33...5203b05. Read the comment docs.

@andrii-bodnar
Copy link
Member

@NazarYavornytskyy what about Unit tests for this case?

@NazarYavornytskyy
Copy link
Contributor Author

@NazarYavornytskyy what about Unit tests for this case?

Let me check it out.

@crowdin-bot
Copy link
Collaborator

SwiftLint found issues

Severity File Reason
Warning CrowdinPathsParserTests.swift:5 Implicitly unwrapped optionals should be avoided when possible. (implicitly_unwrapped_optional)

Generated by 🚫 Danger Swift against 5203b05

@andrii-bodnar andrii-bodnar merged commit 59fffbf into master Feb 15, 2021
@andrii-bodnar andrii-bodnar deleted the Add_two_letters_code_export_patter branch February 15, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants