Improve localization usage #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used local localization in case crowdin localization is missing. Fix issue with handling downloaded localization after localization is changed.
Remove commented code
Fix issue with language changing. Fix issue with language detecting. Add plurals support for localization extrantor.
Generated by 🚫 Danger Swift against f253ac7 |
Add better error handling, notidy anout errors while downloading supported languages and manifest file. Remove SDK modes.
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 50.54% 48.78% -1.76%
==========================================
Files 118 117 -1
Lines 4567 4558 -9
==========================================
- Hits 2308 2223 -85
- Misses 2259 2335 +76
Continue to review full report at Codecov.
|
CrowdinSDK/Classes/CrowdinSDK/Localization/Extractor/LocalLocalizationExtractor.swift
Outdated
Show resolved
Hide resolved
CrowdinSDK/Classes/CrowdinSDK/Localization/Extractor/LocalLocalizationExtractor.swift
Outdated
Show resolved
Hide resolved
CrowdinSDK/Classes/CrowdinSDK/Localization/Extractor/LocalLocalizationExtractor.swift
Outdated
Show resolved
Hide resolved
CrowdinSDK/Classes/CrowdinSDK/Localization/Extractor/LocalLocalizationExtractor.swift
Outdated
Show resolved
Hide resolved
| localizations.insert(Strings.auto.rawValue.capitalized.localized, at: 0) | ||
|
|
||
| self.title = Strings.settings.rawValue.capitalized.localized | ||
| self.navigationItem.rightBarButtonItem = UIBarButtonItem(title: Strings.done.rawValue.capitalized.localized, style: .done, target: self, action: #selector(cancelBtnTapped)) | ||
| self.tableView.register(UITableViewCell.self, forCellReuseIdentifier: "SettingsCell") | ||
| self.tableView.reloadData() |
There was a problem hiding this comment.
A lot of "self" usage, can we remove it?
...lasses/Features/RealtimeUpdateFeature/LocalizationProvider/RURemoteLocalizationStorage.swift
Outdated
Show resolved
Hide resolved
Add gear icon. Remove unused properties from Localization.
Add disconnect handle to SocketManager. Fix issue with saving wrong localization strings after switching language. Fix issue with storing localization strings while realtime-preview feature is enabled. Add method for clearing up local localization storage. Fix issue with starting real-time for the first time. Improve refresh localization option. Improve storing e-tag's for localization files.
… exist on crowdin.
Update pods in Tests project. Set launch arguments for tests target to use en localization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bundled translations if not available on Crowdin