Skip to content

feat: Add support for Task Comments API endpoints#109

Merged
andrii-bodnar merged 3 commits intocrowdin:mainfrom
Bibisha06:task-comment
Oct 20, 2025
Merged

feat: Add support for Task Comments API endpoints#109
andrii-bodnar merged 3 commits intocrowdin:mainfrom
Bibisha06:task-comment

Conversation

@Bibisha06
Copy link
Contributor

@Bibisha06 Bibisha06 commented Oct 18, 2025

Add support for Task Comments API endpoints

Description

This PR adds support for the new Task Comments API in the Crowdin Ruby client library. The following endpoints have been implemented and tested:

  • List Task Comments (list_task_comments)
  • Get Task Comment (get_task_comment)
  • Add Task Comment (add_task_comment)
  • Edit Task Comment (edit_task_comment)
  • Delete Task Comment (delete_task_comment)

All endpoints include corresponding RSpec tests in spec/api_resources/tasks_spec.rb to ensure proper functionality.

Changes Include

  • Updated lib/crowdin-api/api_resources/tasks.rb with methods for the new endpoints.
  • Added tests in spec/api_resources/tasks_spec.rb for:
    • Listing comments
    • Adding a comment
    • Retrieving a comment
    • Editing a comment
    • Deleting a comment

Related Issue

This PR closes #108.

Testing

  • Verified each method with RSpec tests
  • Manual verification in IRB
  • All tests pass successfully

@Bibisha06 Bibisha06 changed the title Add support for Task Comments API endpoints feat: Add support for Task Comments API endpoints Oct 18, 2025
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bibisha06 thank you for the contribution. Please address the CI/CD failures and my comments on the code.

Also, for each method, include a comment with the documentation links. Similarly to the applications resource:

https://github.com/crowdin/crowdin-api-client-ruby/blob/main/lib/crowdin-api/api_resources/applications.rb

Use the relevant Crowdin and Crowdin Enterprise API doc links. https://support.crowdin.com/developer/api/

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (dbcdbd8) to head (efac62f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   98.30%   98.33%   +0.04%     
==========================================
  Files          61       61              
  Lines        2984     3040      +56     
==========================================
+ Hits         2933     2989      +56     
  Misses         51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bibisha06 thank you!

@andrii-bodnar andrii-bodnar merged commit 7bb18db into crowdin:main Oct 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for new Task Comments API

2 participants