Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing groupId inside list glossaries/projects #77

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

dhoko
Copy link
Contributor

@dhoko dhoko commented Apr 25, 2023

Hey 👋

There was a missing groupId for 2 GET calls, It didn't match the API definition for:

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhoko thank you!

@andrii-bodnar
Copy link
Member

@dhoko Unit tests have failed. Could you please take a look?

https://github.com/crowdin/crowdin-api-client-python/actions/runs/4799498715

@dhoko
Copy link
Contributor Author

dhoko commented Apr 26, 2023

@andrii-bodnar ✔️ btw there is an issue with the coverage. When I install the deps it fails at typed_ast :/ (Fedora 37)

│Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune
│=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -fex
│ceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERT
│IONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protec
│tion -D_GNU_SOURCE -fPIC -fwrapv -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,
│-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-ta
│bles -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -fPIC -Iast27/Include -I/home/dhoko/.loca
│l/share/virtualenvs/crowdin-api-client-python-1Vpfnig1/include -I/usr/include/python3.11 -c ast27/Custom/typed_ast.
│c -o build/temp.linux-x86_64-cpython-311/ast27/Custom/typed_ast.o
│      ast27/Custom/typed_ast.c:1:10: fatal error: Python.h: No such file or directory
│          1 | #include "Python.h"
│            |          ^~~~~~~~~~
│      compilation terminated.
│      error: command '/usr/bin/gcc' failed with exit code 1
│      [end of output]
│
│  note: This error originates from a subprocess, and is likely not a problem with pip.
│error: legacy-install-failure
│
│× Encountered error while trying to install package.
│╰─> typed_ast

Then we can't run pytest unless we comment the coverage cf:

diff --git a/setup.cfg b/setup.cfg
index fdbb3b3..7221536 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -60,10 +60,6 @@ addopts =
     --strict-markers
     --tb=short
     --doctest-modules
-    --cov=crowdin_api
-    --cov-report=term-missing:skip-covered
-    --cov-report=xml
-    --cov-fail-under=95

@codecov-commenter
Copy link

Codecov Report

Merging #77 (51fa31b) into main (fa46eee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   99.34%   99.34%   +0.01%     
==========================================
  Files         132      132              
  Lines        4493     4496       +3     
  Branches       95       95              
==========================================
+ Hits         4463     4466       +3     
  Misses         22       22              
  Partials        8        8              
Impacted Files Coverage Δ
...esources/projects/tests/test_projects_resources.py 100.00% <ø> (ø)
crowdin_api/api_resources/glossaries/resource.py 100.00% <100.00%> (ø)
...rces/glossaries/tests/test_glossaries_resources.py 100.00% <100.00%> (ø)
crowdin_api/api_resources/projects/resource.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar
Copy link
Member

@dhoko thank you!

Do you have any ideas regarding this coverage error? Everything seems to work well in the CI/CD pipelines

@dhoko
Copy link
Contributor Author

dhoko commented Apr 26, 2023

Idk ¯_(ツ)_/¯

I saw messages asking to install python3-dev... So I went with no coverage on my computer 😁 It requires no changes and we can still test everything^^

@andrii-bodnar andrii-bodnar merged commit 2da1561 into crowdin:main Apr 26, 2023
@dhoko
Copy link
Contributor Author

dhoko commented Apr 26, 2023

python/typed_ast#179

tl;dr: EOL + I'm using python 3.11 -> no support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants