Skip to content

refactor: Removed format, exportPattern, labelIds and Added bundleIds fields in AddDistribution Api #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrii-bodnar merged 1 commit into from
Jul 19, 2023
Merged

refactor: Removed format, exportPattern, labelIds and Added bundleIds fields in AddDistribution Api #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/main/java/com/crowdin/client/distributions/model/AddDistributionRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,5 @@ public class AddDistributionRequest {
private Enum exportMode;
private String name;
private List<Long> fileIds;
private String format;
private String exportPattern;
private List<Long> labelIds;
private List<Integer> bundleIds;
}
4 changes: 1 addition & 3 deletions src/main/java/com/crowdin/client/distributions/model/Distribution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ public class Distribution {
private String exportMode;
private String name;
private List<Long> fileIds;
private String format;
private String exportPattern;
private List<Long> labelIds;
private List<Integer> bundleIds;
private Date createdAt;
private Date updatedAt;
}
4 changes: 1 addition & 3 deletions src/test/java/com/crowdin/client/distributions/DistributionsApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,8 @@ public void addDistributionTest() {
AddDistributionRequest request = new AddDistributionRequest();
request.setExportMode(ExportMode.BUNDLE);
request.setName(name);
request.setFormat("crowdin-resx");
request.setExportPattern("strings-%two_letter_code%.resx");
request.setFileIds(Collections.singletonList(0L));
request.setLabelIds(Collections.singletonList(0L));
request.setBundleIds(Arrays.asList(1,2,3));
ResponseObject<Distribution> distributionResponseObject = this.getDistributionsApi().addDistribution(projectId, request);
assertEquals(distributionResponseObject.getData().getHash(), hash);
assertEquals(distributionResponseObject.getData().getName(), name);
Expand Down
6 changes: 2 additions & 4 deletions src/test/resources/api/distributions/addDistribution.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
"fileIds": [
0
],
"format": "crowdin-resx",
"exportPattern": "strings-%two_letter_code%.resx",
"labelIds": [
0
"bundleIds": [
1,2,3
]
}
6 changes: 2 additions & 4 deletions src/test/resources/api/distributions/distribution.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@
"fileIds": [
0
],
"format": "crowdin-resx",
"exportPattern": "strings-%two_letters_code%.resx",
"labelIds": [
0
"bundleIds": [
1,2,3
],
"createdAt": "2019-09-16T13:48:04+00:00",
"updatedAt": "2019-09-19T13:25:27+00:00"
Expand Down