Skip to content

Comments

fix: cookie warning#147

Merged
andrii-bodnar merged 1 commit intomasterfrom
fix/cookie-warning
Jun 16, 2023
Merged

fix: cookie warning#147
andrii-bodnar merged 1 commit intomasterfrom
fix/cookie-warning

Conversation

@andrii-bodnar
Copy link
Member

The default HttpClient has difficulty understanding the latest RFC-compliant headers, resulting in WARNING: Invalid cookie header: "Set-Cookie: ...". Invalid 'expires' attribute: ... GMT.

This PR fixes the issue. (based on the StackOverflow answer)

@codecov-commenter
Copy link

Codecov Report

Merging #147 (db09e86) into master (65cb3b3) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #147      +/-   ##
============================================
- Coverage     50.60%   50.51%   -0.09%     
  Complexity      746      746              
============================================
  Files           350      350              
  Lines          3356     3362       +6     
  Branches         90       90              
============================================
  Hits           1698     1698              
- Misses         1638     1644       +6     
  Partials         20       20              
Impacted Files Coverage Δ
...n/client/core/http/impl/http/ApacheHttpClient.java 0.00% <0.00%> (ø)

@andrii-bodnar andrii-bodnar merged commit 9f8dd30 into master Jun 16, 2023
@andrii-bodnar andrii-bodnar deleted the fix/cookie-warning branch June 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants