Remove early return in keyboard enhancement check #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This block sends the query over stdout if the query couldn't be sent over `/dev/tty` successfully. If we send it over stdout we should still query for the response though. The early return prevents that so the response to the query can end up not being consumed.
|
Nice catch! Looks like it was broken in #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This block in the
ifsends the query over stdout if the query couldn't be sent over/dev/ttysuccessfully. If we send it over stdout we should still query for the response though: the early return prevents that so the response to the query might end up not being consumed.This fixes detection for me on Linux. I will test with macOS as well. (Edit: looks good on macOS too)