Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of event types/modifiers with certain keys #716

Merged

Conversation

pianohacker
Copy link
Contributor

When keyboard enhancement is enabled, release/repeat events for certain keys (including Page Up, Page Down, Home, End, etc) are incorrectly parsed as press events.

Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to have this fallback

@TimonPost TimonPost merged commit 263a0fb into crossterm-rs:master Oct 9, 2022
@pianohacker pianohacker deleted the pianohacker_fix_pageup_parsing branch October 16, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants