Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crossterm_style fixes #208

Merged
merged 2 commits into from
Sep 13, 2019
Merged

crossterm_style fixes #208

merged 2 commits into from
Sep 13, 2019

Conversation

zrzka
Copy link
Contributor

@zrzka zrzka commented Sep 13, 2019 •
edited
Loading

  • Removed unused imports
  • Optimised imports (order, ...)
  • As this is the 2018 edition crate, removed extern crate, etc.
  • Fixed style.rs example by removing command() call (no such fn)

cd crossterm_style && cargo test is passing.

@zrzka
Optimize imports (fix warnings, …)
840e30a 
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Remove command() call (no such fn)
fa6224a 
Signed-off-by: Robert Vojta <rvojta@me.com>
TimonPost
TimonPost approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can be merged

@TimonPost TimonPost merged commit 43aa1c2 into crossterm-rs:master Sep 13, 2019
@zrzka zrzka deleted the zrzka/style-fixes branch September 16, 2019 05:47
december1981 pushed a commit to december1981/crossterm that referenced this pull request Oct 26, 2023
@saghm
minor: add compile tests for min stable version and nightly (crosster…
3773666 
…m-rs#208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonPost TimonPost TimonPost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zrzka @TimonPost