Windows 7 grey/white foreground swapped

[MaulingMonkey]

crossterm-style 's WinApiColor backend applies INTENSITY to Grey instead of to White:

• https://github.com/crossterm-rs/crossterm-style/blob/541f9e36ed267c64fadc366e5cf8bd2e4ae2832c/src/winapi_color.rs#L118-L119
• https://github.com/crossterm-rs/crossterm-style/blob/541f9e36ed267c64fadc366e5cf8bd2e4ae2832c/src/winapi_color.rs#L153-L154

Foreground should be swapped around.
Background should be left alone, based on cmd.exe / powershell.exe's behavior.

Background is often - but not always - "wrong" inside of VS Code, including in VS Code's "Default Dark+" theme, but VS Code's themes are an inconsistent and incoherent mess on this front (sometimes INTENSITY makes the background darker in a dark theme, lighter in a dark theme, sometimes it's just plain ignored, sometimes other colors also get inverted brightening behavior, etc. etc. etc.)

Windows 7 (cmd.exe)

• Foreground: Wrong
• Background: OK

The current behavior appears to be correct for backgrounds, but not for foregrounds, as it makes "white" darker than "grey". Using the same flush-heavy demo from #262

Windows 10 (cmd.exe)

• Foreground: OK
• Background: OK

This is just provided as a reference.

Windows 7 (VS Code, Default Dark+ Theme)

• Foreground: Wrong?
• Background: Wrong

Windows 10 (VS Code, Default Dark+ Theme)

• Foreground: OK
• Background: Identical

Test Code

Same as #262 's flush-heavy version:

use crossterm_style::*;
use std::io::{stdout, Write};

fn main() {
    for color in &[Color::Black, Color::DarkGrey, Color::Grey, Color::White] {
        let color = *color;
        print!("{}", Colored::Fg(color));
        stdout().flush().unwrap();
        print!("fore");
        stdout().flush().unwrap();
        print!("{}", Colored::Fg(Color::Reset));
        stdout().flush().unwrap();
        print!(" ");
        stdout().flush().unwrap();
        print!("{}", Colored::Bg(color));
        stdout().flush().unwrap();
        print!("back");
        stdout().flush().unwrap();
        print!("{}", Colored::Bg(Color::Reset));
        stdout().flush().unwrap();
        print!(" {:?}", color);
        stdout().flush().unwrap();
        println!();
    }
}

[TimonPost]

Did you use WinAPI for windows 10? If so, isn't this a windows interpretation problem since Windows 10 seems to be behaving correctly?

[TimonPost]

Powershell windows 10 pro

[MaulingMonkey]

Windows 10 cmd/powershell seems to be behaving OK, presumably because it's using the ANSI backend.

Windows 7 cmd/powershell isn't, presumably because it's using the WinAPI backend.

[TimonPost]

As you see my comment were I disabled ansi you can see that it isn't correct as well. I think we need to swap those colors and see if that fixes the problem

[TimonPost]

Fixed by: crossterm-rs/crossterm-style#5

Powershell WinApi windows 10

CMD WinApi windows 10

CMD Windows 7 WinApi