Remove unsafe globals

[zrzka]

For example, Windows cursor implementation does use ...

static mut SAVED_CURSOR_POS: (u16, u16) = (0, 0);

... to store the cursor position, etc. We have to go through the code, check for other occurrences and fix them.

Occurences:

• style & static mut ORIG_MODE: u32 = 0; (fixed in Refactors crossterm-style#2)
• style & static mut ORIGINAL_CONSOLE_COLOR: u16 = 0; (fixed in Refactors crossterm-style#2)
• utils & pub static mut RAW_MODE_ENABLED: bool = false; (fixed Remove static mut crossterm-utils#5)
• utils & static mut ORIGINAL_TERMINAL_MODE: Option<Termios> = None; (fixed Remove static mut crossterm-utils#5)
• cursor & static mut SAVED_CURSOR_POS: (u16, u16) = (0, 0); (fixed in Internal refactoring and docs crossterm-cursor#2)

[TimonPost]

I actually had that in the past, I would not mind to change it back to lazy_static, I had that code because it would save me a dependency and terminals are single-threaded most of the cases anyways. So feel free to change that back.

[TimonPost]

#248

[zrzka]

terminals are single-threaded most of the cases anyways

• It breaks the Rust safety rule - aliasing & mutation should never happen at the same time if the mutation isn't synchronised.
• Sharing mutable references in Rust is undefined behaviour.
• Generally speaking, people always tend to talk about threads, but they should talk about concurrency and reentrance, because it can happen even without threads.

Can't find the issue now, but there's one about deprecation / removal of the static mut from the Rust language.

[MaulingMonkey]

Can't find the issue now, but there's one about deprecation / removal of the static mut from the Rust language.

rust-lang/rust#53639

[zrzka]

Yep, this one exactly! Thanks :)

[TimonPost]

It looks like all the unsafe statics are removed. This can be closed.