-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 5 #48
Swift 5 #48
Conversation
Hello, Thank you for PR! Can you, please, fix tests? From the first look, it's simply travis.yml fixes (setup proper test environments) |
Sure thing, I'll have a look! |
Alright, all sorted |
One more comment. Seems as we can install swiftenv from the site, not from GitHub gist. Can you update config? |
Ah yes, makes sense. Copied that around like an ancient relic and never checked back for updated installation instructions :) |
Are you planning on pushing out a new release soon? If you're waiting for #47 - I'm happy to jump in and help with the rebase, seeing as most if not all the conflicts are due to my Swift 5 changes and it looks like adjusting that should be really straightforward when you're familiar with the changes. |
Rebase it, if you can. I will create new release |
Here you go: #49 |
Updated targets for Swift 5 and bumped the swift versions where applicable.
I've set up Travis to run on the branch so hopefully the changes in .travis.yml work.