Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 #48

Merged
merged 11 commits into from
Apr 3, 2019
Merged

Swift 5 #48

merged 11 commits into from
Apr 3, 2019

Conversation

finestructure
Copy link
Contributor

@finestructure finestructure commented Mar 28, 2019

Updated targets for Swift 5 and bumped the swift versions where applicable.

I've set up Travis to run on the branch so hopefully the changes in .travis.yml work.

@ypopovych
Copy link
Member

Hello,

Thank you for PR!

Can you, please, fix tests? From the first look, it's simply travis.yml fixes (setup proper test environments)

@finestructure
Copy link
Contributor Author

Sure thing, I'll have a look!

@finestructure
Copy link
Contributor Author

Alright, all sorted

@ypopovych
Copy link
Member

One more comment. Seems as we can install swiftenv from the site, not from GitHub gist.
Check https://swiftenv.fuller.li/en/latest/integrations/travis-ci.html

Can you update config?

@finestructure
Copy link
Contributor Author

Ah yes, makes sense. Copied that around like an ancient relic and never checked back for updated installation instructions :)

@ypopovych ypopovych merged commit efd275e into crossroadlabs:master Apr 3, 2019
@finestructure finestructure deleted the swift-5 branch April 4, 2019 04:16
@finestructure
Copy link
Contributor Author

Are you planning on pushing out a new release soon?

If you're waiting for #47 - I'm happy to jump in and help with the rebase, seeing as most if not all the conflicts are due to my Swift 5 changes and it looks like adjusting that should be really straightforward when you're familiar with the changes.

@ypopovych
Copy link
Member

Rebase it, if you can. I will create new release

@finestructure
Copy link
Contributor Author

Here you go: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants