Stable Swift 4 support #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Regex/RegexOptions.swift
|
Hi, @Coder-256 . Thanks for PR. You did a lot of work. I want to merge it, but I need several small changed from you:
I will merge it and publish a new version. Thanks, |
This reverts commit 5bb273c.
|
I already signed the CLA, but I think you or @dileping still has to. Also, I fixed the README. |
|
Thanks. Seems like a bug in clahub. Because we signed it too. (And I saw old PR from you, where you signed it). I will check everything tomorrow and merge it. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull if you want. Stable Swift 4 support, tagged
2.0.0. Now it is fully working.